Cleaning up mistakes and invalid code. #211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General clean up on a bad commit on my part from last night. Also styling for the newly edited markup conventions.
Member
|
These images shouldn't be in Also, does this pull request supersede #208? Please confirm @kleinmaetschke so we can close the old one. |
Contributor
Author
|
Supersedes #208, will address the images when I get to a computer. |
Contributor
|
@ajpiano in general, shouldn't the css reference images in the theme and the html content reference images in the resources directory? |
Member
|
Yes. The css does not reference these images, they are used as resources from the content directory, so they should be here at all. |
Contributor
|
Ok, thanks |
Removing the images not referenced in CSS.
Member
|
I'm not sure if this is still relevant, but it won't merge cleanly anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General clean up on a bad commit on my part from last night. Also styling for the newly edited markup conventions.